Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: runtime metrics UI #747

Merged
merged 28 commits into from
May 10, 2023
Merged

feat: runtime metrics UI #747

merged 28 commits into from
May 10, 2023

Conversation

4nalog
Copy link
Member

@4nalog 4nalog commented Apr 19, 2023 •
edited
Loading

TL;DR

This PR adds logic for allowing runtime task metrics to me displayed in the timeline chart component

To run:

  • setup the project by cloning
  • run yarn install and yarn start
  • navigate to a specific workflow and check out the timeline view

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

This feature:

  • add logic to fetch task level runtime metrics in the timeline view using the new workflow execution metrics api
  • destructures the data returned from the workflow execution metrics api to get values from the corresponding phases in detail based on the operation id
  • displays those as a chart on the timeline

Tracking Issue

fixes

@codecov
Copy link

codecov bot commented Apr 19, 2023 •
edited
Loading

Codecov Report

Merging #747 (49f906d) into master (e28a142) will decrease coverage by 0.19%.
The diff coverage is 49.62%.

❗ Current head 49f906d differs from pull request most recent head 3bc01f9. Consider uploading reports for the commit 3bc01f9 to get more accurate results

@@            Coverage Diff             @@
##           master     #747      +/-   ##
==========================================
- Coverage   66.09%   65.90%   -0.19%     
==========================================
  Files         488      489       +1     
  Lines       11806    11914     +108     
  Branches     2171     2195      +24     
==========================================
+ Hits         7803     7852      +49     
- Misses       4003     4062      +59
Impacted Files Coverage Δ
...cutionDetails/Timeline/TimelineChart/barOptions.ts 0.00% <0.00%> (ø)
.../ExecutionDetails/Timeline/TimelineChart/index.tsx 0.00% <0.00%> (ø)
...ole/src/components/Workflow/useWorkflowInfoItem.ts 51.16% <0.00%> (-2.50%) ⬇️
...ges/console/src/components/common/DetailsPanel.tsx 92.30% <ø> (ø)
packages/console/src/models/Common/constants.ts 100.00% <ø> (ø)
packages/console/src/models/Execution/api.ts 46.77% <50.00%> (+0.10%) ⬆️
packages/console/src/models/Execution/utils.ts 75.00% <50.00%> (-2.78%) ⬇️
...sole/src/components/Entities/EntityDescription.tsx 79.62% <57.14%> (-1.51%) ⬇️
...s/ExecutionDetails/Timeline/TimelineChart/utils.ts 78.26% <65.21%> (-13.58%) ⬇️
...ges/console/src/components/hooks/useDescription.ts 66.66% <75.00%> (-3.34%) ⬇️
... and 6 more

@tsheiner
Copy link

@4nalog here I am

@tsheiner
Copy link

@4nalog I can run this, but I don't see any partitioning of the timeline graph. Also I'm seeing the height issue you reported earlier.
Screenshot 2023-04-25 at 10 45 10 AM

@4nalog 4nalog changed the title [WIP] feat: runtime metrics UI feat: runtime metrics UI Apr 26, 2023
@4nalog 4nalog marked this pull request as ready for review April 26, 2023 21:44
@4nalog 4nalog requested a review from jsonporter April 26, 2023 21:45
@tsheiner
Copy link

@4nalog I can run this but when I look at any timeline view, I do not see the the chart lines partitioned, do not get a detail pop up.

What am I missing?
Screenshot 2023-04-27 at 7 57 47 AM

@jsonporter
Copy link
Contributor

Bugs per our sync with @hamersaw:

  • Diff on seconds first
  • append nanos (if present) to result of seconds diff.

@tsheiner
Copy link

tsheiner commented May 2, 2023

@4nalog I see two issues:

  • the way the tooltip animates is not OK; it kind of flys in from somewhere. Please just fade it up in .5ms at mouse position.
  • I think we are still drawing the lines partitioning the bar; please suppress.

@ursucarina ursucarina force-pushed the feat/runtime-metrics branch 2 times, most recently from a461b4b to 50a16b5 Compare May 10, 2023 20:56
4nalog and others added 19 commits May 10, 2023 13:57
@4nalog @ursucarina
feat: runtime metrics
c4aed52
@4nalog @ursucarina
feat: add mock data
e75a795
@4nalog @ursucarina
fix: chart distance spacing breaking
0c901df
@4nalog @ursucarina
chore: use traversal logic to get operation id from nodes
a209ccf
@4nalog @ursucarina
chore: minor fixes
f07566d 
Signed-off-by: Soham <4nalog@protonmail.com>
@4nalog @ursucarina
fix: phase color
24708f2
@4nalog @ursucarina
chore: threshold on milliseconds
a5294ad
@4nalog @ursucarina
chore: add borders
b3b241a
@4nalog @ursucarina
feat: runtime metrics
0083bb9
@4nalog @ursucarina
chore: minor fixes
fadfbfb
@4nalog @ursucarina
chore: remove tooltip datasets, sanitize tooltip design
b1c95f8
@jsonporter @ursucarina
Added parsing function for span data
8c4342f 
Signed-off-by: Jason Porter <jason@union.ai>
@4nalog @ursucarina
chore: minor fixes
6437a66
@4nalog @ursucarina
chore: minor fixes
b9d550a
@4nalog @ursucarina
chore: minor fixes
53b0899
@4nalog @ursucarina
chore: minor fixes
fe9faa7
@4nalog @ursucarina
fix: width
ce5257d
@4nalog @ursucarina
chore: remove highlight, fix fonts
4c5375e
@jsonporter @ursucarina
fixed parsing algo to include node operations
648db01 
Signed-off-by: Jason Porter <jason@union.ai>
4nalog and others added 6 commits May 10, 2023 13:57
@4nalog @ursucarina
chore: support ms
e4f48d3
@4nalog @ursucarina
fix: formatting
4c14b8a
@4nalog @ursucarina
chore: cleanup
1f7f465
@jsonporter @ursucarina
Minor fixes
17865a6 
Signed-off-by: Jason Porter <jason@union.ai>
@jsonporter @ursucarina
Fixed formatting issue with displayed duration
2b7436e 
Signed-off-by: Jason Porter <jason@union.ai>
@ursucarina
chore: fix yarn.lock
ccdec21 
Signed-off-by: Carina Ursu <carina@union.ai>
@ursucarina ursucarina requested review from a team, ursucarina, olga-union and james-union and removed request for a team May 10, 2023 21:15
@4nalog
fix: add space
3bc01f9 
Signed-off-by: Soham <4nalog@protonmail.com>
@jsonporter jsonporter merged commit 29babaa into master May 10, 2023
9 checks passed
@jsonporter jsonporter deleted the feat/runtime-metrics branch May 10, 2023 21:39
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@jsonporter jsonporter mentioned this pull request May 16, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsonporter jsonporter jsonporter approved these changes

@ursucarina ursucarina Awaiting requested review from ursucarina ursucarina was automatically assigned from flyteorg/fe-engineers

@olga-union olga-union Awaiting requested review from olga-union olga-union was automatically assigned from flyteorg/fe-engineers

@james-union james-union Awaiting requested review from james-union james-union was automatically assigned from flyteorg/fe-engineers

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
5 participants
@4nalog @tsheiner @jsonporter @flyte-bot @ursucarina